On Fri, 27 Apr 2007 16:41:12 -0700 (PDT), Linus Torvalds wrote: > And the reason I _hate_ attachements is that you cannot say "no, that one > is wrong", and just skip/edit it. Well, skipping it while applying the rest is bad form anyway, isn't it? I think "bounce the whole series on any problem" reduces load on the maintainer and helps the submitter learn by fixing up the patch series personally rather than trusting the maintainer to do it. > And when patch 5 is crap, you're basically screwed. There is almost no > support for replying to that _individually_ and saying "That one sucks". > You press "reply", and you get all ten. As soon as there's anything broken in the series, the patch boundaries aren't that interesting to me anymore. At that point, I just reply to the whole thing and strip the reply down to the stuff worth commenting on. So, my style is accept or bounce, and during the bounce, I'll just review the whole thing while quoted in my reply buffer. That seems to work for me anyway, without a one-patch-per email approach, (in fact, one-patch-per-email would be a lot more awkward for replying to the whole series and quoting similar or related issues as I like to do). -Carl
Attachment:
pgphNOd9Dg1G3.pgp
Description: PGP signature