On 12/07, Duy Nguyen wrote: > On Wed, Dec 7, 2016 at 4:51 AM, Brandon Williams <bmwill@xxxxxxxxxx> wrote: > > Convert 'create_simplify()' to use the pathspec struct interface from > > using the '_raw' entry in the pathspec. > > It would be even better to kill this create_simplify() and let > simplify_away() handle struct pathspec directly. > > There is a bug in this code, that might have been found if we > simpify_away() handled pathspec directly: the memcmp() in > simplify_away() will not play well with :(icase) magic. My bad. If > :(icase) is used, the easiest/safe way is simplify nothing. Later on > maybe we can teach simplify_away() to do strncasecmp instead. We could > ignore exclude patterns there too (although not excluding is not a > bug). So are you implying that the simplify struct needs to be killed? That way the pathspec struct itself is being passed around instead? -- Brandon Williams