On 06/12/16 18:26, Jeff King wrote: > On Tue, Dec 06, 2016 at 10:17:55AM -0800, Junio C Hamano wrote: > >> Yup, that is what I meant to say with "that is already possible" and >> we are on the same page. As all three of us seem to be happy with >> just dropping --abbrev and letting describe do its default thing (as >> configured by whoever is doing the build), let's do so. >> >> -- >8 -- >> From: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> >> Date: Sun, 4 Dec 2016 20:45:59 +0000 >> Subject: [PATCH] GIT-VERSION-GEN: do not force abbreviation length used by 'describe' > > Thanks, this is a nice summary of the discussion, and the patch is > obviously correct. Yep, looks very good to me! (I had started to write a commit message for this patch, when your email arrived. Needless to say, but your message is much better than mine!) Thanks! ATB, Ramsay Jones