On 5 December 2016 at 21:24, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Luke Diamand <luke@xxxxxxxxxxx> writes: > >> On 5 December 2016 at 20:53, Junio C Hamano <gitster@xxxxxxxxx> wrote: >>> Luke Diamand <luke@xxxxxxxxxxx> writes: >>> >>>> Teach git-p4 about git-workspaces. >>> >>> Is this what we call "git worktree", or something else? >> >> Ah, I think you're right! > > Then I'll queue it like the attached. > > HOWEVER. > > How fast does isValidGitDir() function need to be? It doesn't need to be fast. > The primary one > seems to check HEAD (but it does not notice a non-repository that > has a directory with that name), refs and objects (but it does not > notice a non-repository that has a non-directory with these names), > and this new one uses a test that is even more sloppy. > > What I am trying to get at is if we want to use a single command > that can be given a path and answer "Yes, that is a repository" > here, and that single command should know how the repository should > look like. I offhand do not know we already have such a command we > can use, e.g. "git rev-parse --is-git-dir $path", but if there isn't > perhaps we would want one, so that not just "git p4" but other > scripted Porcelains can make use of it? That would be nicer than random ad-hoc rules, certainly. I couldn't find any obvious combination that would work. Luke