Re: [PATCH 31/35] pathspec: allow querying for attributes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/10, Stefan Beller wrote:
> +static void parse_pathspec_attr_match(struct pathspec_item *item, const char *value)
> +{
>
> [...]
>
> +	if (!item->attr_check)
> +		git_attr_check_initv(&item->attr_check, attrs.argv);
> +	else
> +		die(_("Only one 'attr:' specification is allowed."));
> +
> +	argv_array_clear(&attrs);
> +	string_list_clear(&list, 0);
> +	return;
> +}

Unnecessary return statement, maybe you want to remove it?

-- 
Brandon Williams



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]