Re: [PATCHv2 2/3] submodule-config: rename commit_sha1 to commit_or_tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 21, 2016 at 4:11 PM, Brandon Williams <bmwill@xxxxxxxxxx> wrote:
> On 11/21, Stefan Beller wrote:
>>
>>       switch (lookup_type) {
>> @@ -448,7 +448,8 @@ static const struct submodule *config_from(struct submodule_cache *cache,
>>
>>       /* fill the submodule config into the cache */
>>       parameter.cache = cache;
>> -     parameter.commit_sha1 = commit_sha1;
>> +     // todo: get the actual tree here:
>
> s/todo/TODO
>
> Makes it more clear that this is a TODO
>

The // is more annoying here. I'll review these changes closely
before sending out v3.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]