On Mon, Nov 21, 2016 at 1:01 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Stefan Beller <sbeller@xxxxxxxxxx> writes: > >> Subject: Re: [PATCH 1/3] submodule: use absolute path for computing relative path connecting > > connecting what? IOW, has the subject line somehow truncated? > >> This addresses a similar concern as in f8eaa0ba98b (submodule--helper, >> module_clone: always operate on absolute paths, 2016-03-31) >> >> When computing the relative path from one to another location, we >> need to provide both locations as absolute paths to make sure the >> computation of the relative path is correct. > > Can the effect of this change demonstrated in a new test? There > must be a scenario where the current behaviour is broken and this > change fixes an incorrect computation of relative path, no? > I found the latest patch of this series broken without this patch. I'll try to find existing broken code, though.