On Thu, Nov 17, 2016 at 2:57 AM, Heiko Voigt <hvoigt@xxxxxxxxxx> wrote: > It seems that you are only looking at the submodule config from a > commit. Should a user be able to override this with local configuration? > Haven't looked further in the patchseries so maybe that is somewhere > else? It turns out that in later patches we pass in null_sha1 only, which is looking at the config and possible overrides. I'll refactor to take no sha1 argument and use null_sha1 here directly.