> -----Original Message----- > From: Stefan Beller [mailto:sbeller@xxxxxxxxxx] > Sent: Tuesday, November 15, 2016 6:07 PM > Cc: git@xxxxxxxxxxxxxxx; bmwill@xxxxxxxxxx; gitster@xxxxxxxxx; > jrnieder@xxxxxxxxx; mogulguy10@xxxxxxxxx; David Turner; Stefan Beller > Subject: [PATCH 07/16] update submodules: introduce > submodule_is_interesting > +int submodule_is_interesting(const char *path, const unsigned char > +*sha1) { This is apparently only ever (in this series) called with null_sha1. So either this arg is unnecessary, or there are bugs elsewhere in the code.