>> >> /* >> @@ -370,7 +368,7 @@ static void align_atom_handler(struct atom_value *atomv, struct ref_formatting_s >> push_stack_element(&state->stack); >> new = state->stack; >> new->at_end = end_align_handler; >> - new->at_end_data = &atomv->u.align; >> + new->at_end_data = &atomv->atom->u.align; > > At first, this confused me. I was like "we dropped the union, why are > we still referencing it. But I realized that the "used_atom" struct > actually contains the same union and we were copying it. > > Ok, so this looks good. > It is confusing if one only looks at the patch without actually going through ref-filter.c. I'm sure your comment will help anyone going through these patches. -- Regards, Karthik Nayak