On 11/07, Jeff King wrote: > > + test_expect_success "clone $desc (env var has precedence)" ' > > + rm -rf tmp.git && > > + ( > > + GIT_ALLOW_PROTOCOL=none && > > + export GIT_ALLOW_PROTOCOL && > > + test_must_fail git -c protocol.$proto.allow=always clone --bare "$url" tmp.git > > + ) > > + ' > > This test is a good addition in this round. > > I suppose we could test also that GIT_ALLOW_PROTOCOL overrides > protocol.allow, but I'm not sure if there is a point. If git were a > black box, it's a thing I might check, but we know from the design that > this is an unlikely bug (and that the implementation is unlikely to > change in a way to cause it). So I could go either way. I'll add in another test for that, no reason not to test it. > > Squashable documentation suggestions are below. > Sounds good -- Brandon Williams