On Tue, Nov 1, 2016 at 10:31 AM, Stefan Beller <sbeller@xxxxxxxxxx> wrote: > On Tue, Nov 1, 2016 at 10:20 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > >> >> Maybe I am old fashioned, but I'd feel better to see these with >> explicit "extern" in front (check the older header files like >> cache.h when you are in doubt what the project convention has been). > > I did check the other files and saw them, so I was very unsure what to > suggest here. I only saw the extern keyword used in headers that were > there when Git was really young, so I assumed it's a style nit by kernel > developers. Thanks for clarifying! > > I think we'll want to have some consistency though, so we > maybe want to coordinate a cleanup of submodule.h as well as > submodule-config.h to mark all the functions extern. > > This doesn't need to be a all-at-once thing, but we'd keep it in mind > for future declarations in the header. > > Thanks, > Stefan Extern is generally used when you want to declare a header for a function that's in a different object file. I'm not sure if we actually need it or not though. Thanks, Jake