On 11/01/2016 01:37 PM, Junio C Hamano wrote:
Junio C Hamano <gitster@xxxxxxxxx> writes:
Jonathan Tan <jonathantanmy@xxxxxxxxxx> writes:
Currently, a line is interpreted to be a trailer line if it contains a
separator. Make parsing stricter by requiring the text on the left of
the separator, if not the empty string, to be of the "<token><optional
whitespace>" form.
Hmph. The optional whitespace is to allow for what kind of line?
It is not for "Signed off by:" that is a misspelt "Signed-off-by:";
it may not hurt but I do not think of a case that would be useful
offhand.
This is to allow trailers of the form "Fix #42" (mentioned in the
git-interpret-trailers documentation and also in the test).
Other than this "Hmph" (which is not an objection---just something
that the reviewer did not understand), the rest looked good to me.
Will re-queue.
Thanks.
Thanks!