(sorry if this should have been answered if I went through the series patch by patch, I wanted to do a proper review but finally have to admit to myself I won't, so I just skim through a single giant diff instead) On Sun, Oct 23, 2016 at 6:32 AM, Stefan Beller <sbeller@xxxxxxxxxx> wrote: > +attr;; > +After `attr:` comes a space separated list of "attribute > +requirements", all of which must be met in order for the > +path to be considered a match; What about (attr=abc def,attr=ghi lkj)? Does it mean (abc && def) || (ghi && lkj), or abc && def && ghi && lkj? Or is it forbidden to have multiple 'attr' attribute in the same pathspec? -- Duy