> On 21 Oct 2016, at 06:08, Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > > Hi Junio & Lars, > > On Thu, 20 Oct 2016, Junio C Hamano wrote: > >> * ls/filter-process (2016-10-17) 14 commits >> (merged to 'next' on 2016-10-19 at ffd0de042c) >> + contrib/long-running-filter: add long running filter example >> + convert: add filter.<driver>.process option >> + convert: prepare filter.<driver>.process option >> + convert: make apply_filter() adhere to standard Git error handling >> + pkt-line: add functions to read/write flush terminated packet streams >> + pkt-line: add packet_write_gently() >> + pkt-line: add packet_flush_gently() >> + pkt-line: add packet_write_fmt_gently() >> + pkt-line: extract set_packet_header() >> + pkt-line: rename packet_write() to packet_write_fmt() >> + run-command: add clean_on_exit_handler >> + run-command: move check_pipe() from write_or_die to run_command >> + convert: modernize tests >> + convert: quote filter names in error messages >> >> The smudge/clean filter API expect an external process is spawned >> to filter the contents for each path that has a filter defined. A >> new type of "process" filter API has been added to allow the first >> request to run the filter for a path to spawn a single process, and >> all filtering need is served by this single process for multiple >> paths, reducing the process creation overhead. >> >> Will merge to 'master'. > > This breaks in Git for Windows' SDK (I only now realized that t0060 was > not the only thing breaking in `next` for a while now): > ... > -- snap -- > > Unsurprisingly, bisect identifies "convert: add filter.<driver>.process > option" as the first bad commit, although it only fails on the test case > 15, but not on 17. > > I am unfortunately still busy with trying to figure out what exactly makes > t6030 hang on `pu` (seems it thinks stdin is a tty and just waits for an > answer), and then trying to reduce that insane amount of time wasted on > running, and waiting for, the test suite, and for unrelated reasons I'll > have to go offline for the rest of the day, so I will most likely be > unable to assist further with this. Hi Johannes, thanks for reporting this. Looks like I misunderstood your comment when you wrote the error is already fixed in GfW: https://github.com/git-for-windows/git/issues/770#issuecomment-251426487 I think this patch series (referenced by the link above, too) should fix the problem: http://public-inbox.org/git/20160905211111.72956-1-larsxschneider@xxxxxxxxx/ Don't waste any time on this. I will look into it ASAP (traveling right now). Cheers, Lars