Hello Shawn, Shawn O. Pearce wrote: > "Shawn O. Pearce" <spearce@xxxxxxxxxxx> wrote: > > Uwe Kleine-K??nig <ukleinek@xxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > > > commit-tree failed: > > > Warning: commit message does not conform to UTF-8. > > This was starting to bug me, so I went off and found it. OK, well > the encoding error anyway. git-gui incorrectly claimed commit-tree > failed when it didn't. But besides the point, this is the bad line: > > > 1294 fconfigure $msg_wt -encoding $enc -translation binary > > I have had trouble in the past with trying to use that magic > -encoding flag on fconfigure to get Tcl's file channels to perform > encoding work for me. Seems it doesn't work right or something... > so other parts of git-gui (e.g. the filename handling parts) > perform the convertfrom/convertto logic on their own... but the > commit message handling parts didn't. > > They do now (git gui 0.6.5-11-gf20db5f). > > Can you please test my current master branch and see if that fixes > things for you? repo.or.cz, git-gui.git... Works fine. I pulled in your changes[1] and it worked with one test case. (I amended the merge and added a sign-off. ;-) Best regards and thanks Uwe [1] Thanks to gitster in #git to explain how to do it. It's as easy as: git pull -s subtree git://.../git-gui.git master -- Uwe Kleine-König http://www.google.com/search?q=gravity+on+earth%3D - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html