On Wed, Oct 19, 2016 at 03:46:48AM -0400, Jeff King wrote: > FWIW, I gave it a fairly thorough read-over (something I'd been meaning > to do for quite a while, but kept never quite getting around to). I > think overall it is OK for next. I did find one or two nits, but I think > they are things we can fix up in-tree if and when they become a problem > (e.g., I noticed that test-genrandom gets piped to "perl -pe". I'm not > sure if perl will complain about funny multibyte characters on some > systems. I suggest we ignore it until somebody demonstrates that it > actually matters). I just looked, and that use is fine. perl -pe is always going to treat its data as bytes unless you use -C or explicitly enable Unicode functionality. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: https://keybase.io/bk2204
Attachment:
signature.asc
Description: PGP signature