> On 15 Oct 2016, at 14:01, Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> wrote: > > > > On 15/10/16 16:05, Lars Schneider wrote: >>> On 11 Oct 2016, at 16:46, Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> wrote: > [snip] >>> -void stop_multi_file_filter(struct child_process *process) >>> +static void stop_multi_file_filter(struct child_process *process) >> >> Done! Do you have some kind of script to detect these things >> automatically or do you read the code that carefully? > > Heh, I'm _far_ too lazy to read the code that carefully. :-D > > A combination of 'make sparse' and a perl script (originally > posted to the list by Junio) find all of these for me. Interesting. Do you have a link to this script? Does it generate false positives? Maybe I can add `make sparse` to the TravisCI build? Cheers, Lars