On Tue, Oct 11, 2016 at 11:40 AM, Brandon Williams <bmwill@xxxxxxxxxx> wrote: > Wouldn't a +1 indicate that the attr name is valid while the 0 > indicates that it is invalid? Right. > It looks to me like we are checking each > character and if we run into one that doesn't work then we have an error > and return 0 indicating that the attr name we are checking is invalid, > otherwise the name is valid and we would want to return a +1 indicating > a success. > > Am I understanding the intent of this function properly? > I will change it to +1; I was just rambling about when you may expect -1 in this project. :)