Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > In the end, I decided to actually *not* use strbuf_add_unique_abbrev() > here because it really makes the code very much too ugly after the > introduction of short_commit_name(): It's perfectly fine not to use that function when it does not make sense; we shouldn't use it (or anything for that matter) just for the sake of using it.