Heiko Voigt <hvoigt@xxxxxxxxxx> writes: > +static int append_hash_to_argv(const unsigned char sha1[20], void *data) > +{ > + struct argv_array *argv = (struct argv_array *) data; > + argv_array_push(argv, sha1_to_hex(sha1)); > + return 0; > +} Do we have struct object_id readily available in the caller? ... goes and looks ... No, this is part of sha1_array API, so this callback is perfectly fine.