Re: [PATCH] remote.c: free previous results when looking for a ref match

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] remote.c: free previous results when looking for a ref match
From: Stefan Beller <sbeller@xxxxxxxxxx>
Date: Mon, 10 Oct 2016 10:03:22 -0700
Cc: Junio C Hamano <gitster@xxxxxxxxx>, "git@xxxxxxxxxxxxxxx" <git@xxxxxxxxxxxxxxx>
In-reply-to: <e9f58e04-a534-6794-feac-f6a47ca8bb65@web.de>
References: <20161007235857.20382-1-sbeller@google.com> <e9f58e04-a534-6794-feac-f6a47ca8bb65@web.de>

On Sat, Oct 8, 2016 at 6:38 AM, René Scharfe <l.s.r@xxxxxx> wrote:

>
> Again, this check is not necessary.  If I read the code correctly the
> pointer could be uninitialized at that point, though, causing free(3) to
> crash.

yep, this patch is bogus.

References:
- [PATCH] remote.c: free previous results when looking for a ref match
  - From: Stefan Beller
- Re: [PATCH] remote.c: free previous results when looking for a ref match
  - From: René Scharfe

Prev by Date: Re: [PATCH] t4014-format-patch: Adjust git_version regex to better handle distro changes to DEF_VER
Next by Date: Re: [PATCH] t3700-add.sh: Avoid filename collission between tests which could lead to test failure
Previous by thread: Re: [PATCH] remote.c: free previous results when looking for a ref match
Next by thread: Feature request: use relative path in worktree config files
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]