On Thu, Oct 6, 2016 at 2:23 AM, Heiko Voigt <hvoigt@xxxxxxxxxx> wrote: > On Wed, Oct 05, 2016 at 03:53:25PM +0200, Heiko Voigt wrote: >> On Tue, Oct 04, 2016 at 02:03:58PM -0700, Stefan Beller wrote: >> > Jeff, >> > thanks for the suggestions, both git_path(..) as well as checking the config, >> > this seems quite readable to me: >> >> When reading the discussion I thought the same: What about the >> "old-style" repositories. I like this one. Checking both locations >> is nice. > > BTW, since it seems we all agree on the direction. Should we add some > tests? > Good call. What do we want to test for? * Correctness in case of submodules? (just push and get rejected) I think that is easy to do. * Performance with [no, lots of] submodules? That seems harder to me. I'll add a test for the correctness part and resend. Thanks, Stefan