> On 06 Oct 2016, at 11:32, Johannes Schindelin <johannes.schindelin@xxxxxx> wrote: > > Hi Junio & Lars, > > On Wed, 5 Oct 2016, Junio C Hamano wrote: > >> Lars Schneider <larsxschneider@xxxxxxxxx> writes: >> >>> OK. Something like the patch below would work nicely. >> >> Yeah, something along that line; it would eliminate the need to >> worry about a field named "stdin" ;-) > > Not only a need to worry. Git for Windows' SDK's headers define > > #define stdin (&__iob_func()[0]) > > leading to the compile error > > In file included from git-compat-util.h:159:0, > from cache.h:4, > from run-command.c:1: > run-command.c:25:6: error: expected identifier or '(' before '&' token > int stdin; > ^ > > I meant to investigate this build failure of `pu` earlier but only got > around to do it today. > > Ciao, > Dscho Sorry for the trouble. The "stdin" will go away in the next round as we agreed on a more generic solution: http://public-inbox.org/git/1FD7FB64-0F40-47F0-A047-25B91B170E66@xxxxxxxxx/ - Lars