On Wed, Oct 05, 2016 at 03:58:53PM +0200, Jakub Narębski wrote: > I would prefer the following: > > # A --> B --> C --> D --> E --> F --> G --> H > # 0 1 2 3 4 5 6 Yeah, that is also more visually pleasing. Here's a squashable update that uses that and clarifies the points in the discussion with Jacob. Junio, do you mind squashing this in to jk/alt-odb-cleanup? diff --git a/t/t5613-info-alternate.sh b/t/t5613-info-alternate.sh index b393613..62170b7 100755 --- a/t/t5613-info-alternate.sh +++ b/t/t5613-info-alternate.sh @@ -39,13 +39,16 @@ test_expect_success 'preparing third repository' ' ) ' -# Note: These tests depend on the hard-coded value of 5 as "too deep". We start -# the depth at 0 and count links, not repositories, so in a chain like: +# Note: These tests depend on the hard-coded value of 5 as the maximum depth +# we will follow recursion. We start the depth at 0 and count links, not +# repositories. This means that in a chain like: # -# A -> B -> C -> D -> E -> F -> G -> H -# 0 1 2 3 4 5 6 +# A --> B --> C --> D --> E --> F --> G --> H +# 0 1 2 3 4 5 6 # -# we are OK at "G", but break at "H". +# we are OK at "G", but break at "H", even though "H" is actually the 8th +# repository, not the 6th, which you might expect. Counting the links allows +# N+1 repositories, and counting from 0 to 5 inclusive allows 6 links. # # Note also that we must use "--bare -l" to make the link to H. The "-l" # ensures we do not do a connectivity check, and the "--bare" makes sure @@ -59,11 +62,11 @@ test_expect_success 'creating too deep nesting' ' git clone --bare -l -s G H ' -test_expect_success 'validity of fifth-deep repository' ' +test_expect_success 'validity of seventh repository' ' git -C G fsck ' -test_expect_success 'invalidity of sixth-deep repository' ' +test_expect_success 'invalidity of eighth repository' ' test_must_fail git -C H fsck '