On Tue, Oct 4, 2016 at 9:11 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > > The question git_all_attrs() asks is quite different. And as far as I can tell it is only used by builtin/check-attr.c which we do not intend to convert into a threaded beast in the foreseeable future I'd expect. So maybe we can just punt on redefining the API there, i.e. we keep the question and answer together in a struct git_attr_check. <some return value here> git_all_attr(const char *path); /* no other arguments except path*/ That looks great, and I incorporated that into the proposal I sent out as an RFC.