On Tue, Oct 4, 2016 at 6:47 AM, Jeff King <peff@xxxxxxxx> wrote: > On Mon, Oct 03, 2016 at 10:52:39PM -0700, Jacob Keller wrote: > >> On Mon, Oct 3, 2016 at 1:34 PM, Jeff King <peff@xxxxxxxx> wrote: >> > Our normal test style these days puts the opening quote of >> > the body on the description line, and indents the body with >> > a single tab. This ancient test did not follow this. >> > >> >> I was surprised you didn't do this first, but it doesn't really make a >> difference either way. This is also a pretty straight forward >> improvement, and I can see why you'd want to split this out to review >> separately. > > I was trying to leave it to the end, to move the substantive changes up > front (and because there _isn't_ a correct style for some of the things > it was doing). But it just got too painful to do the "don't chdir" patch > without updating the style. I agree it might have made more sense at the > very beginning, but I didn't think it mattered enough to go through the > trouble of rebasing the earlier patches (which would essentially be > rewriting them). > > -Peff Right. Thanks, Jake