On Thu, Sep 29, 2016 at 2:48 PM, Brandon Williams <bmwill@xxxxxxxxxx> wrote:
>
> +const char *get_super_prefix(void)
> +{
> + if (!super_prefix)
> + super_prefix = getenv(GIT_SUPER_PREFIX_ENVIRONMENT);
> + return super_prefix;
> +}
> +
As said earlier, is the following a valid thought:
> The getenv() function returns a pointer to the value in the
> environment, or NULL if there is no match.
> So in case this is not set (when e.g. the user did not specify the
> super prefix), we would probe it a couple of times.
> The caching effect only occurs when the string is set. So this looks
> like we save repetitive calls, but we do not always do that.
>
> + if (get_super_prefix()) {
> + die("%s doesn't support --super-prefix", argv[0]);
> + }
> +
Nit: no braces, please.