Jeff King <peff@xxxxxxxx> writes: > On Mon, Oct 03, 2016 at 10:02:14AM -0700, Junio C Hamano wrote: > >> The timeout would be good for you to give a message "filter process >> running the script '%s' is not exiting; I am waiting for it". The >> user is still left with a hung Git, and can then see if that process >> is hanging around. If it is, then we found a buggy filter. Or we >> found a buggy Git. Either needs to be fixed. I do not think it >> would help anybody by doing a kill(2) to sweep possible bugs under >> the rug. > > I would argue that we should not even bother with such a timeout. This > is an exceptional, buggy condition, and hanging is not at all restricted > to this particular case. If git is hanging, then the right tools are > "ps" or "strace" to figure out what is going on. I know that not all > users are comfortable with those tools, but enough are in practice that > the bugs get ironed out, without git having to carry a bunch of extra > timing code that is essentially never exercised. OK.