On Mon, Oct 3, 2016 at 1:34 PM, Jeff King <peff@xxxxxxxx> wrote: > Besides being our normal style, this correctly checks for an > error exit() versus signal death. > Another very simple but obvious improvement. Regards, Jake > Signed-off-by: Jeff King <peff@xxxxxxxx> > --- > t/t5613-info-alternate.sh | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/t/t5613-info-alternate.sh b/t/t5613-info-alternate.sh > index 4548fb0..65074dd 100755 > --- a/t/t5613-info-alternate.sh > +++ b/t/t5613-info-alternate.sh > @@ -46,10 +46,9 @@ git clone -l -s F G && > git clone --bare -l -s G H' > > test_expect_success 'invalidity of deepest repository' \ > -'cd H && { > - git fsck > - test $? -ne 0 > -}' > +'cd H && > +test_must_fail git fsck > +' > > cd "$base_dir" > > @@ -75,7 +74,8 @@ cd "$base_dir" > test_expect_success 'that info/alternates is necessary' \ > 'cd C && > rm -f .git/objects/info/alternates && > -! (git fsck)' > +test_must_fail git fsck > +' > > cd "$base_dir" > > @@ -89,7 +89,7 @@ cd "$base_dir" > test_expect_success \ > 'that relative alternate is only possible for current dir' ' > cd D && > - ! (git fsck) > + test_must_fail git fsck > ' > > cd "$base_dir" > -- > 2.10.0.618.g82cc264 >