On Mon, Oct 3, 2016 at 3:27 PM, Jeff King <peff@xxxxxxxx> wrote:
>
> + if (len < 0) {
> + unsigned long count = approximate_object_count();
> + len = (msb(count) + 1) / 2;
> + if (len < 0)
> + len = FALLBACK_DEFAULT_ABBREV;
> + }
that second "if (len < 0)" should probably be testing against
FALLBACK_DEFAULT_ABBREV, not zero. Or at the very least
MINIMUM_ABBREV. Because a two-character abbreviation won't even be
recognized, even if the git project is very small indeed.
Linus