Re: bug with gitweb on kernel.org

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2007-04-19 at 23:02 -0400, Nicolas Pitre wrote:
> Almost 2 months ago we discussed about gitweb not properly detecting the 
> client's ability to deal with application/xhtml+xml, something to do 
> with the caching of a previous request from a client which did support 
> it and serving the same content to a subsequent client which does not.

I apparently missed that entire conversation, my apologies.

> 
> Right now www.kernel.org/git is unusable for me with lynx as it keeps 
> prompting:
> 
> 	application/xhtml+xml  D)ownload, or C)ancel
> 
> Is there any plan to have that fixed?
> 

Well there are a couple of quick thoughts, so far (in my quick testing)
lynx and IE are the only two browsers that have issues with this
particular bit of code.  Links, konqueror, safari, firefox, mozilla, etc
all seem to handle the pages without issue.  Taking a quick glance at
the code it seems IE claims to be xhtml+xml compliant but apparently
isn't really (any real surprise?) and lynx just doesn't seem to support
that mime type.

The simplest fix would be to eliminate the distinction between
applicatoin/xhtml+xml and application/html in the gitweb code (or at
least in the caching gitweb code) and have everything claim a mimetype
of application/html and let the browser sort out if it's using xhtml or
html from the doctype.  This would solve both the problem your seeing on
lynx and would make the caching gitweb usable by more IE users.

Some quick testing on my part seems to indicate this doesn't break
behavior for any of the clients I have access to, but I thought I'd
check and see if anyone had any concerns over this particular change
before I barrel ahead with it in the caching gitweb code.

- John 'Warthog9' Hawley

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]