On Fri, Sep 30, 2016 at 3:01 AM, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > On Thu, Sep 29, 2016 at 5:56 PM, Mike Hommey <mh@xxxxxxxxxxxx> wrote: >> >> OTOH, how often does one refer to trees or blobs with abbreviated sha1s? >> Most of the time, you'd use abbreviated sha1s for commits. And the number >> of commits in git and the kernel repositories are much lower than the >> number of overall objects. > > See that whole other discussion about this. I agree. If we only ever > worried about just commits, the abbreviation length wouldn't need to > be grown nearly as aggressively. The current default would still be > wrong for the kernel, but it wouldn't be as noticeably wrong, and > updating it to 8 or 9 would be fine. > > That said, people argued against that too. We *do* end up having > abbreviated SHA1's for blobs in the diff index. When I said that _I_ > neer use it, somebody piped up to say that they do. > > So I'd rather just keep the existing semantics (a hash is a hash is a > hash), and just abbreviate at a sufficient point that we don't have to > worry too much about disambiguating further by object type. I work on a repo that's around the size of linux.git in every way (commits, objects etc.), and growing twice as fast. So I also see 8 or 9 digit abbreviations on a daily basis, even with the current defaults core.abbrev, but I still think growing it so aggressively is the wrong thing to do. The fact that we have a core.abbrev option at all and nobody's talking about getting rid of it entirely means we all acknowledge the UX convenience of short SHA1s. I don't think it's a good idea for such UX options to have defaults that really only make sense for repositories at the very far end of the bell curve, which is the case with linux.git and the repo I work on. Either way you're going to waste somebody's time. I think it's a better trade-off that some kernel dev occasionally has to look at Peff's new disambiguation output, than have the wast hordes of everyday Git users have less screen real estate, need to recite longer sha1s over the phone during outages (people do that), and any number of other every day use cases. I think if anything we should be talking about making the default shorter & then have some clever auto-scaling by repository size as has been discussed in this thread to deal with the repositories at the far end of the bell curve.