On Fri, Sep 30, 2016 at 11:40 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>
> There is another instance buried deep in an obscure macro. A
> minimum fix may look like this, but I really hope somebody else
> finds a better approach.
Heh. Yeah, that's just ugly. I assume this is why the odd git fetch
pretty-printing test was off by one column..
Considering that TRANSPORT_SUMMARY and TRANSPORT_SUMMARY_WIDTH are
both used in exactly one place each, I'd suggest getting rid of that
crazy macro, and just expanding it in those places to avoid these
kinds of crazy "hiding variables inside complex defines thning".
And maybe just deciding to hardcode TRANSPORT_SUMMARY_WIDTH to 17
(which was it's original default value and presumably is what the test
is effectively hardcoded for too), and avoiding that complexity
entirely.
Linus