Re: [PATCH] unpack_sha1_header(): detect malformed object header

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] unpack_sha1_header(): detect malformed object header
From: Jeff King <peff@xxxxxxxx>
Date: Mon, 26 Sep 2016 13:38:16 -0400
Cc: git@xxxxxxxxxxxxxxx, Karthik Nayak <karthik.188@xxxxxxxxx>, Gustavo Grieco <gustavo.grieco@xxxxxxx>
In-reply-to: <xmqqoa3atviv.fsf@gitster.mtv.corp.google.com>
References: <1825523389.8224664.1474812766424.JavaMail.zimbra@imag.fr> <xmqqbmzbwmfc.fsf@gitster.mtv.corp.google.com> <xmqqshsnuvvz.fsf_-_@gitster.mtv.corp.google.com> <20160926140309.l2h4b65gpqyutepn@sigill.intra.peff.net> <xmqqfuomvdqe.fsf@gitster.mtv.corp.google.com> <xmqqoa3atviv.fsf@gitster.mtv.corp.google.com>

On Mon, Sep 26, 2016 at 10:34:32AM -0700, Junio C Hamano wrote:

> And the second one, that no longer checks SP in unpacker, looks like
> this.

This looks good from a cursory read (but I am about to go to sleep, so
might be a bit less careful than usual :) ).

-Peff

References:
- Stack read out-of-bounds in parse_sha1_header_extended using git 2.10.0
  - From: Gustavo Grieco
- Re: Stack read out-of-bounds in parse_sha1_header_extended using git 2.10.0
  - From: Junio C Hamano
- [PATCH] unpack_sha1_header(): detect malformed object header
  - From: Junio C Hamano
- Re: [PATCH] unpack_sha1_header(): detect malformed object header
  - From: Jeff King
- Re: [PATCH] unpack_sha1_header(): detect malformed object header
  - From: Junio C Hamano
- Re: [PATCH] unpack_sha1_header(): detect malformed object header
  - From: Junio C Hamano

Prev by Date: Re: [PATCH 06/10] get_short_sha1: NUL-terminate hex prefix
Next by Date: Re: [PATCH 10/10] get_short_sha1: list ambiguous objects on error
Previous by thread: Re: [PATCH] unpack_sha1_header(): detect malformed object header
Next by thread: Re: Stack read out-of-bounds in parse_sha1_header_extended using git 2.10.0
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]