On Sun, Sep 25, 2016 at 08:46:39PM -0700, Junio C Hamano wrote: > Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> writes: > > > I can just keep reminding kernel maintainers and developers to update > > their git config, but maybe it would be a good idea to just admit that > > the defaults picked in 2005 weren't necessarily the best ones > > possible, and those could be bumped up a bit? > > > > I think I mentioned this some time ago, and it's not a huge deal, but > > I thought I'd just mention it again because it came up again today for > > me.. > > I am not quite sure how good any new default would be, though. Just > like any timeout is not long enough for somebody, growing projects > will eventually hit whatever abbreviation length they start with. I actually think "12" might be sane for a long time. That's 48 bits of sha1, so we'd expect a 50% change of a _single_ collision at 2^24, or 16 million. The biggest repository I know about (in number of objects) is the one holding all of the objects for all of the forks of torvalds/linux on GitHub. It's at about 15 million objects. Which _seems_ close, but remember that's the size where we expect to see a single collision. They don't become common until much later (I didn't compute an exact number, but Linus's 16x sounds about right). I know that the growth of the kernel isn't really linear, but I think the need to bump to "13" might not just be decades, but possibly a century or more. So 12 seems reasonable, and the only downside for it (or for "13", for that matter) is a few extra bytes. I dunno, maybe people will really hate that, but I have a feeling these are mostly cut-and-pasted anyway. > I am not opposed to bump the default to 12 or whatever, but I > suspect any lengthening today may need to be accompanied by a tool > support that finds the set of objects that are reachable from a > commit whose names begin with non-unique abbreviations that appear > in the commit log message. Assuming that it is very hard to refer to > future objects in the log message you write today, such a tool may > find a single object that used to be the unique instance of that > abbreviation back then, and with reachability bitmap support, it may > not be too expensive to run. I had a similar thought, but I think it's not just reachability. You might refer to a short sha1 on an alternate branch that isn't reachable from you. Or you may even use the short sha1 in an email message or a bug tracker. So I think the extra context you want is probably a timestamp: at time t, what was a reasonable guess for this sha1? That's easy to answer for commits and tags (cull the ones that are too new), but harder for blobs and trees (you'd want to know the earliest commit which contains them). An easier (but less automatic) tool would be to improve our error message for the ambiguous case, and actually report details of the candidates. I'm working up a patch now. -Peff
