Junio C Hamano <gitster@xxxxxxxxx> wrote: > lists@xxxxxxxxxxxxxxxx (Stefan Haller) writes: > > > Thanks, this is interesting; I'm having trouble understanding the tests > > though. Some of them use rebase -p -i, but I don't understand why they > > use -i, or why that even works in a test (i.e. why it doesn't open an > > editor). > > Upon starting up, tests dot-source t/test-lib.sh file and it > unsets most of GIT_* environment variables to obtain a stable > testing environment that is not affected by things that testers > may have in their environment. > > There is EDITOR=: in t/test-lib.sh, which was added in 2006 before > GIT_EDITOR was invented. That is the one in effect for git > subcommands that usually interacts with editors during the test, > unless specific tests further override it with test_set_editor > helper. Thanks for the explanation. So this explains why -i works at all here; it doesn't explain why -i is used in these tests. Unless I'm missing something, they should all work with just -p. And I don't see any tests that do rebase -p -i and actually do something interesting with the -i part. So my original question still remains. :-) -- Stefan Haller Berlin, Germany http://www.haller-berlin.de/