Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: > I think a separate commit for this is better than combining back to > 2/3 so we can explain the problem properly (without making 2/3 commit > message even longer) > > Not sure if you want to s/contains/contain/ in 2/3 by yourself or I > should resend the whole series. Let me know. OK, I just amended it before applying this on top. > + flags |= INIT_DB_EXIST_OK; > + return init_db(git_dir, real_git_dir, template_dir, flags); I do not think of anything better, but EXIST_OK does not sound grammatical. "REINIT" is not quite it--we are merely allowing the function to re-init if there already is a repository. And OK_TO_REINIT is a bit too long. Let's take the patch as-is for now. Thanks.