Jonathan Tan <jonathantanmy@xxxxxxxxxx> writes: > With the above change, it is actually no longer necessary to make > is_scissors_line take plain char * (the second patch) - I think that > that patch still improves the code, but let me know if you want me to > remove it from this patch set. I agree with you that it is an independently good change. Let's keep it. Overall looked very good. Thanks, will queue.