side question if the answer is short: Any reason as to why all of the pathspec matching code lives inside of dir.c and not pathspec.c? On Mon, Sep 19, 2016 at 11:22 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Brandon Williams <bmwill@xxxxxxxxxx> writes: > >> Yes in that case it wouldn't have passed ps_strncmp()...but we should have never >> made it there in the first place due to a piece of logic in match_pathspec_item: > > Ah, OK. > > Thanks for clarifying.