Martin Koegler, Sat, Apr 21, 2007 14:26:17 +0200: > If the mode parameter is not NULL, get_sha1 will store > the mode of the object in it. It looks like the number of call sites which actually use the argument is vanishingly small compared to the number of sites where it is set to NULL. Why don't you introduce a new function instead, say get_sha1_and_mode, and use it for this two or three places? - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html