On Thu, Sep 15, 2016 at 08:31:00PM +0200, René Scharfe wrote: > Replace uses of strbuf_addf() for adding strings with more lightweight > strbuf_addstr() calls. This makes the intent clearer and avoids > potential issues with printf format specifiers. > > 02962d36845b89145cd69f8bc65e015d78ae3434 already converted six cases, > this patch covers eleven more. Great, these all look obviously correct. > A semantic patch for Coccinelle is included for easier checking for > new cases that might be introduced in the future. I think there was some discussion in brian's object_id patches about whether we wanted to carry Coccinelle transformations in the tree, but I don't remember the outcome. I don't have an opinion myself. > Silly question: Is there a natural language that uses percent signs > as letters or e.g. instead of commas? :) I don't know, but if they do, they'd better get used to escaping them. :) -Peff