On Tue, Sep 13, 2016 at 4:06 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Stefan Beller <sbeller@xxxxxxxxxx> writes:
>
>> +struct line_emission {
>> + const char *set;
>> + const char *line;
>> + const char *ws;
>> + const char *reset;
>> + int first;
>> + int len;
>> + int whitespace_check;
>> + unsigned ws_rule;
>> + int has_trailing_carriage_return;
>> + int has_trailing_newline;
>> +};
>
> It is somewhat strange to see whitespace things are per-line here.
> I'd understand it if it were per-path, though.
Yeah we have to have it at least per path as that is the granularity
the user can configure it.
So would we rather want to keep the ecbdata around for each file pair and
just reference that? I thought we deliberately want to avoid ecbdata, so maybe
we rather want to have another struct that keeps path related information
around (pointer to the blob and white space information).
Thanks,
Stefan