On Fri, Sep 09, 2016 at 05:32:21PM +0700, Duy Nguyen wrote: > On Fri, Sep 9, 2016 at 3:02 AM, Jeff King <peff@xxxxxxxx> wrote: > > On Thu, Sep 08, 2016 at 08:47:18PM +0700, Nguyễn Thái Ngọc Duy wrote: > > > >> git-init somehow reads '.git/config' at current directory and sets > >> log_all_ref_updates based on this file. Because log_all_ref_updates is > >> not unspecified (-1) any more. It will not be written to the new repo's > >> config file (see create_default_files() function). > >> > >> This will affect our tests in the next patch as we will compare the > >> config file and expect that core.logallrefupdates is already set to true > >> by "git init main-worktree". > > > > This is a bug for more than worktrees, and is something I'm working on > > fixing > > Great! test_expect_failure it is. But I'll make a separate patch, > independent from this series though. If you're curious what the fix looks like, it's in: https://github.com/peff/git jk/config-repo-setup The actual fix is in the final patch, but it needed a lot of preparatory work to avoid breaking various programs that made bad assumptions (and in the process, I uncovered a ton of other minor bugs). This is just a preview in case you're interested, for two reasons: 1. I literally _just_ put the finishing touches on it, and it's extensive and tricky enough that I really should give it one more proofread. 2. There may be other related fallouts from the bug related to running "git init /path/to/foo" when "/path/to/foo" already exists (and in that case we _do_ want to read its config, but not the config from an existing repository). This may all just work fine, but I need to think about some tests. -Peff