On Thu, Sep 08, 2016 at 11:54:08AM -0700, Josh Triplett wrote: > > your problem description > > looks perfect. I am still not sure if the code does a reasonable > > thing in MIME case, though. > > It *looks* correct to me. Hmm. It looks correct to me, too; we stick it just after the patch, so with "--attach" it is part of the text/x-patch, which is reasonable. But looking at the results of "--attach" from _before_ your patch, it looks totally broken. The "base" information comes _after the final delimiter of the multipart/mixed. Most mailers would just throw it away when decoding the multipart, I think. So this is actually fixing a bug, and you could probably add a test (though I am not sure we have anything in git that actually parses multipart messages _or_ that carefully consumes the base-commit info, so it might be hard to test in practice). -Peff