Re: [PATCH v3 0/8] Better heuristics make prettier diffs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 7, 2016 at 11:11 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Michael Haggerty <mhagger@xxxxxxxxxxxx> writes:
>
>> * In "blame: honor the diff heuristic options and config":
>>
>>   * In v2, I suggested making `blame` honor all diff-related options.
>>     Junio explained why this was a bad idea. So this version only
>>     makes `blame` honor `--indent-heuristic` and
>>     `--compaction-heuristic`.
>
> This makes a lot more sense to me.  I am not sure if it is worth
> adding 7/8 to expose these experimental knobs to the end users, but
> the amount of the code needed is very small, so let's take it.
>
> I am hoping that we can lose both of the experimental knobs and use
> the indent heuristic unconditionally in the future, though ;-)
>
> Thanks.
>


Agreed, I think we should drop the knobs and use the feature
unconditionally as well.

Thanks,
Jake



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]