Christian Couder <christian.couder@xxxxxxxxx> writes: > In patch 29/41 I added some comments in apply.h above the definition > of APPLY_OPT_INACCURATE_EOF and APPLY_OPT_RECOUNT, as suggested by > Stefan. This is the only change compared to v13. OK. > - Patches 33/41 to 37/41 were in v10, v12 and v13. > > They implement a way to make the libified apply code silent by > changing the bool `apply_verbosely` into a tristate enum called > `apply_verbosity`, that can be one of `verbosity_verbose`, > `verbosity_normal` or `verbosity_silent`. This is a reasonable approach. > The only changes since v13 are in 37/41. The name of the first > argument to mute_routine() is changed from "bla" to "msg" as suggested > by Ramsey, and the commit message is improved as suggested by Stefan. ;-) > - Patch 40/41 was in v12 and v13, and hasn't changed. > > It adds a "const char *index_file" into "struct apply_state", to make > it possible to use a special index file instead of the default one. Looks sensible.