We usually try to avoid doing any significant actions outside of test blocks. Although "rm -rf" is unlikely to either fail or to generate output, moving these to the point of use makes it more clear that they are part of the overall setup of "clone.git". Signed-off-by: Jeff King <peff@xxxxxxxx> --- t/t5305-include-tag.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t5305-include-tag.sh b/t/t5305-include-tag.sh index f314ad5..6018404 100755 --- a/t/t5305-include-tag.sh +++ b/t/t5305-include-tag.sh @@ -25,7 +25,6 @@ test_expect_success setup ' } >obj-list ' -rm -rf clone.git test_expect_success 'pack without --include-tag' ' packname_1=$(git pack-objects \ --window=0 \ @@ -33,6 +32,7 @@ test_expect_success 'pack without --include-tag' ' ' test_expect_success 'unpack objects' ' + rm -rf clone.git && ( GIT_DIR=clone.git && export GIT_DIR && @@ -51,7 +51,6 @@ test_expect_success 'check unpacked result (have commit, no tag)' ' test_cmp list.expect list.actual ' -rm -rf clone.git test_expect_success 'pack with --include-tag' ' packname_1=$(git pack-objects \ --window=0 \ @@ -60,6 +59,7 @@ test_expect_success 'pack with --include-tag' ' ' test_expect_success 'unpack objects' ' + rm -rf clone.git && ( GIT_DIR=clone.git && export GIT_DIR && -- 2.10.0.rc2.154.gb4a4b8b