On Sun, 2016-09-04 at 18:08 +0200, Michael Haggerty wrote: > +/* A linked list of ref_stores for submodules: */ > +static struct ref_store *submodule_ref_stores; I don't like the per-submodule stores being in a linked list, which requires a linear search. Stefan has, I think, been doing a bunch of work to scale git to support on the order of thousands of submodules, which this potentially breaks. What about a hashmap?