Re: [PATCH] introduce hex2chr() for converting two hexadecimal digits to a character

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi René,

On Sat, 3 Sep 2016, René Scharfe wrote:

> Add and use a helper function that decodes the char value of two
> hexadecimal digits.  It returns a negative number on error, avoids
> running over the end of the given string and doesn't shift negative
> values.

I like it! Maybe stress a little bit why this is a good change? Like, DRY
up code, makes the code safer (bt avoiding shifting negative values)?

>  6 files changed, 21 insertions(+), 78 deletions(-)

Very, very nice!

Thanks,
Dscho

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]